Integrate serde into LanguageServerCodec #215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
LanguageServerCodec
to encode/decodeT: Serialize + DeserializeOwned
items instead ofString
objects.Server
code a bit, now thatLanguageServerCodec
handles JSON de/serialization directly.trace!()
logs fromtransport.rs
tocodec.rs
.Fixed
Instead of processing message headers in
codec.rs
and de/serializing JSON separately intransport.rs
, both now occur in one step inside the codec'sEncoder
andDecoder
implementations. This simplification happened to also uncover a bug in the codec's parse error recovery, which has been fixed.