Fix server support for $/cancelRequest #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the `RequestKind::CancelRequest` struct variant is defined incorrectly, meaning client-to-server `$/cancelRequest` notifications are silently ignored. This seems to have been broken for a long time. I discovered this by intentionally adding a 1500ms async delay to the `LanguageServer::did_change` method in `examples/stdio.rs`. When this method is invoked on the server, the unexpected delay causes the client to emit a `$/cancelRequest` notification to the server. After opening a new text buffer and starting to type, I successfully confirmed the `$/cancelRequest` notification was indeed being emitted by the client, but the server wasn't showing any successful request cancellation logs.
|
Due to the criticality of this bug, I think this PR might warrant an immediate patch release after merging. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
lsp_types::NumberOrStringandtower_lsp::jsonrpc::Id.cancels_pending_requestsunit test to catch future regressions.Fixed
RequestKind::CancelRequeststruct-like variant definition.Closes #281.