Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cancel request log from warn to debug #353

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

sdankel
Copy link
Contributor

@sdankel sdankel commented Sep 28, 2022

This log message occurs often and should really be DEBUG or INFO rather than WARN level.

This log message occurs often and should really be DEBUG or INFO rather than WARN level.
Copy link
Owner

@ebkalderon ebkalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable change to me! Most attempts to cancel pending server-side requests tend to fail, due to how quickly request handlers tend to resolve, so I suppose this would be an easy way to cut down on log noise.

@sdankel
Copy link
Contributor Author

sdankel commented Jan 11, 2023

Makes sense! Feel free to merge, I don't have permissions to do so. Thanks!

@ebkalderon
Copy link
Owner

Will do! Apologies for the delay; still looking for time after work to give it a real-world usability test on my end. I'll merge this PR as soon as I can.

@ebkalderon
Copy link
Owner

Okay, I've just given this a go. Looks great! Thanks again for this pull request.

@ebkalderon ebkalderon merged commit e8d703d into ebkalderon:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants