Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove any-types and Mod class #1204

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Remove any-types and Mod class #1204

merged 2 commits into from
Feb 15, 2024

Commits on Feb 15, 2024

  1. Remove untyped arguments from LocalModList 

    In practice all mod arguments are of ManifestV2 type. Refer to this
type consistently as "mod", and use "tsMod" for the few occurances of
ThunderstoreMod types.
    @anttimaki
    anttimaki committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d2a2be6 View commit details
    Browse the repository at this point in the history

  2. Remove Mod class 

    The class was no longer used directly, only by ThunderstoreVersion
which extends it. Relevant attributes and getters/setters were moved
to ThunderstoreVersion definition. Mod.fromManifest was dropped since
it's not used and did return a Mod object anyway.
    @anttimaki
    anttimaki committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    bbd7ea6 View commit details
    Browse the repository at this point in the history