Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DisableModModal more self-sustained #1216

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Make DisableModModal more self-sustained #1216

merged 5 commits into from
Feb 22, 2024

Commits on Feb 22, 2024

  1. DisableModModal: assimilate dependants list 

    There's no need to pass dependants list as a prop since it can be as
easily be determined internally.

Dependency list prop was dropped altogether since it's not used.
    @anttimaki
    anttimaki committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    df2ad26 View commit details
    Browse the repository at this point in the history

  2. DisableModModal: manage open/closed state in Vuex

    @anttimaki
    anttimaki committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5baca5e View commit details
    Browse the repository at this point in the history

  3. ProfileModule: add support for disabling mods via Vuex store 

    The implementation imitates what's currently being done by
LocalModList.performDisable().

This helps remove business logic and driect references to providers
from components, hopefully supporting reuse and easier refactoring.
    @anttimaki
    anttimaki committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    359f57e View commit details
    Browse the repository at this point in the history

  4. DisableModModal: assimilate rest of the props 

    The modal now handles disabling of mods entirely internally.
    @anttimaki
    anttimaki committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    72afea0 View commit details
    Browse the repository at this point in the history

  5. LocalModCard: don't delegate mod disabling to LocalModList 

    LocalModCard now disables mods without dependants internally, and
delegates mods with dependants to DisableModModal, effectively cutting
out the middleman LocalModList.
    @anttimaki
    anttimaki committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    578ab72 View commit details
    Browse the repository at this point in the history