Make LocalModCard more self-sustained #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation imitates what's currently being done by LocalModList.performEnable(). Execption is that the new implementation supports similar "progress indicator" as the disabling method does, even though it's not currently used since mods are never enabled via modal where the progress could be shown, even if multiple mods are enabled at once. This helps remove business logic and direct references to providers from components, hopefully supporting reuse and easier refactoring.
- I'm not sure if this is the proper way to test components that rely on state stored in Vuex, but it's the first of many ways I tried that worked - Tests need to await $nextTick() so the async created() method is done before the test cases continue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.