Separate Create Profile modal from Profiles.vue #1355
Conversation
VilppeRiskidev
commented
Jun 6, 2024
VilppeRiskidev
commented
- TODO: clean up old create profile stuff from Profiles.vue, which is easier to do with the refactoring of the Import module as the two were somewhat convoluted.
There was a problem hiding this comment.
Didn't do a proper review yet, but the start seems as it should 👍🏻
One thing you might want to consider, is to centralize the methods shared between multiple profile modals, e.g. get profileList, makeProfileNameSafe, doesProfileExist. See e.g. how Profiles.vue uses ProfileMixin.vue. That being said, the mixin adds a bit of complexity and requires jumping between files when reading the code, so it might not be worth it if only few methods are duplicated between two files. (On the other hand it's quite nice from maintenance perspective if r2mm and tsmm have different implementations of the component that uses the mixin, like Profiles does.)
| </template> | ||
|
|
||
| <template v-slot:body> | ||
| <p>This profile will store its own mods independently from other profiles.</p> |
There was a problem hiding this comment.
Seems something is off style-wise. The input no longer has vertical white space, causing this help text and the validation tags below cling to it.
There was a problem hiding this comment.
Ideally some scoped CSS would've been used, but I guess this works too.
- TODO: clean up old create profile stuff from Profiles.vue, which is easier to do with the refactoring of the Import module as the two were somewhat convoluted.
VilppeRiskidev
force-pushed
the
create-profile-modal-refactor
branch
from
f4ad406
to
2769c27
Compare
