Clean up ThunderstoreDownloaderProvider #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove references to settings and active game from the download provider, as these were mostly used to only access the setting telling whether to ignore the cached mod downloads. Instead pass the settings as a boolean argument. Implement related changes to provider implementation and their callsites. In downloadAndSave, switch to checking the variable for ignoring the cache first, before checking if the mod actually exists on the disk, as this might reduce the number of unnecessary file operations.
anttimaki
force-pushed
the
download-provider-cleanup
branch
from
25ebc4d
to
c146695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove references to settings and active game from the download provider, as these were mostly used to only access the setting telling whether to ignore the cached mod downloads. Instead pass the settings as a boolean argument.
Implement related changes to provider implementation and their callsites.
In downloadAndSave, switch to checking the variable for ignoring the cache first, before checking if the mod actually exists on the disk, as this might reduce the number of unnecessary file operations.