Refactor GameSelectionScreen's "proceed" methods #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also turn the if-check around to save an indentation level. Refs TS-1139
Vue component doesn't need to know what activating a game consists of. Refs TS-1139
Vue component doesn't need to know what providers need to be setup and how it's done when the active game is selected. Refs TS-1139
The switch statement in the Vue component seemed unnecessary: all three valid options did the exact same thing. Refs TS-1139
Due to z-index, the modal was shown partially below the search bar in GameSelectionScreen.
MythicManiac
approved these changes
Oct 18, 2022
ebkr
approved these changes
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.