Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions workflow for building the app #862

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

anttimaki
Copy link
Collaborator

The workflow attemps to build Electron apps based on the Quasar config. Apps are built on Windows, Linux and Mac platforms. Hopefully this will catch changes that break things before they're merged to master/develop branches.

Refs TS-1218

The workflow attemps to build Electron apps based on the Quasar config.
Apps are built on Windows, Linux and Mac platforms. Hopefully this will
catch changes that break things before they're merged to master/develop
branches.

Refs TS-1218
Copy link
Owner

@ebkr ebkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but otherwise looks good and appears to work

uses: StarUbiquitous/command-output@v1.0.1 # Store stdout/stderr to outputs.
# You might want to turn this on if there's problems with electron-builder.
# env:
# DEBUG: electron-builder
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we gain by having this off?
Is it storage related? Faster builds?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just quite verbose, outputting some 600 lines of debug info. I thought it might actually make it more difficult to spot the actual problem amidst all the noise.

@MythicManiac MythicManiac merged commit b6a739d into develop Nov 9, 2022
@MythicManiac MythicManiac deleted the ci-build branch November 9, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants