Navigation menu refactor #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main purpose is to make the functionality for ensuring a game dir is set reusable in other places. While refactoring, the implementation was changed so that the game dir is no longer set if it was set already. I'm not 100% certain I read the code correctly, but it seems to me the old implementation would only set the current value again, which is a no-op. Refs TS-530
The main purpose is to make the functionality reusable in other places, but this also DRYs up the NavigationMenu quite nicely. resolveGameDir checks two separate directories, which seems a bit odd but I'm so unfamiliar with the project that there's probably a good reason for it and I've left that as it was. Refs TS-530
MythicManiac
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a remake of #799 that also takes into account a review comment from a forked repo's PR. The changes in the other repo got stuck in limbo as the plans changed, but are now needed in this repo as a part of a larger navbar refactoring which aims to make it possible to easily customise the navigation in TSMM.