Refactor DownloadModModal #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MythicManiac
changed the base branch from
standalone-category-filter-modal
to
standalone-category-filter-modal-rebased
MythicManiac
changed the base branch from
standalone-category-filter-modal-rebased
to
standalone-category-filter-modal
* Remove the prop that controls the modal visibility. Manage it via Vuex store instead * Remove the prop that defines which mod to download/update. The value is passed to Vuex store as a part of the open modal command instead * Remove "update all mods" prop. The value can be derived from whether there's a mod to download/update set or not * Since the props were removed, there's no longer a need to render duplicate modals in LocalModList and OnlineModList components The motivation for the refactoring is to support breaking the Manager page into smaller, more manageable pieces, which in turn allows easier customization. Refs TS-1321
anttimaki
force-pushed
the
downloadmodmodal-refactor
branch
from
e7f95e1
to
b6a8d07
Compare
anttimaki
changed the base branch from
standalone-category-filter-modal
to
standalone-category-filter-modal-rebased
MythicManiac
approved these changes
Nov 29, 2022
ebkr
approved these changes
Nov 29, 2022
Base automatically changed from
standalone-category-filter-modal-rebased
to
develop
November 29, 2022 19:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for the refactoring is to support breaking the Manager page into smaller, more manageable pieces, which in turn allows easier customization.
Refs TS-1321