Fix Xbox Game Pass directory resolver bugs #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug in the Xbox Game Pass directory resolver where an if check unintentionally always returned true due to a missing await keyword. Also modify the error handling block to not fail if something that doesn't have a message attribute attached to it is thrown.
ebkr
reviewed
Nov 29, 2022
src/providers/generic/game/directory_resolver/win/XboxGamePassDirectoryResolver.ts
Show resolved
Hide resolved
ebkr
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in the Xbox Game Pass directory resolver where an if check unintentionally always returned true due to a missing await keyword.
Also modify the error handling block to not fail if something that doesn't have a message attribute attached to it is thrown.