Decouple category filter modal #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MythicManiac
commented
Nov 28, 2022
There was a problem hiding this comment.
A few questions, otherwise looks good. Can't approve this myself since I re-opened the PR on behalf of @anttimaki
Some of the filters in manager page are managed via a modal. Having the modal inside the Manager page makes it difficult to move towards route based navigation. But before the modal can be moved out of the manager page, we need to move the management of filter state to make them universally accessible. Refs TS-1309
Continue making Manager page less of a god-class component. This also partially fixes the problem where "allow NSFW" checkbox didn't react correctly to dark/light theme. The value is now read from correct place, so the checkbox is themed based on the theme that was active when user entered Manager page. However, if user changes the theme while on manager page, the checkbox theme is not updated yet. I wasn't sure how this should be solved, and it falls outside the scope of the ticket, so I just marked the issue with TODO comment. Refs TS-1309
anttimaki
force-pushed
the
standalone-category-filter-modal-rebased
branch
from
eb22e8c
to
88b199d
Compare
anttimaki
approved these changes
Nov 29, 2022
ebkr
approved these changes
Nov 29, 2022
Rename a variable from cats to categories as requested in PR review. Not squashing to previous commit as to avoid creating conflicts in the PR chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #879 as some commits in #879 had to be merged ahead of time; this PR is the re-ordered result.
This should be merged after #886