Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed dotnet from ConfigSelectionLayout.vue #949

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Removed dotnet from ConfigSelectionLayout.vue #949

merged 2 commits into from
Jan 23, 2023

Conversation

ebkr
Copy link
Owner

@ebkr ebkr commented Jan 20, 2023 •
edited
Loading

TODO

  • Remove dotnet folder from new exports

MythicManiac
MythicManiac approved these changes Jan 21, 2023
View reviewed changes
Copy link
Collaborator

@MythicManiac MythicManiac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but should we also exclude these from exports?

That can be done separately even if we do though, so feel free to merge this.

@ebkr
Copy link
Owner Author

ebkr commented Jan 22, 2023

Good catch, they probably should. Will add a task.

@ebkr ebkr merged commit fcce9dd into develop Jan 23, 2023
@ebkr ebkr deleted the ignore-dotnet-folder-for-configs branch January 23, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MythicManiac MythicManiac MythicManiac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebkr @MythicManiac