forked from nolte/cert-manager-webhook-duckdns
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change of implementation of the domain to use ChallengeRequest DNSName #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrianne
changed the title
[WiP] #3 Change of implementation of the domain to use ChallengeRequest DNSName
[WiP] Change of implementation of the domain to use ChallengeRequest DNSName
Mar 24, 2021
ebrianne
changed the title
[WiP] Change of implementation of the domain to use ChallengeRequest DNSName
[WIP] Change of implementation of the domain to use ChallengeRequest DNSName
Mar 24, 2021
Tested with kind 1.20.2
Request of certificate with two different wildcard domains ---
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: services-***-duckdns-org
namespace: services
spec:
dnsNames:
- '*.<domain1>.duckdns.org'
- '*.<domain2>.duckdns.org'
issuerRef:
name: cert-manager-webhook-duckdns-production
kind: ClusterIssuer
secretName: services-****-duckdns-org-tls Certificate issued perfectly
|
… rbac, cleaning go mod
Fix #2 by downgrading to v1.19.0 go-client |
ebrianne
changed the title
[WIP] Change of implementation of the domain to use ChallengeRequest DNSName
Change of implementation of the domain to use ChallengeRequest DNSName
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It tries to remove the domain value in the ClusterIssuer and to get the domain name based on the ChallengeRequest DNSNames that are provided when requesting a certificate.
It still needs to be able to handle multiple dns names inside the request (may need some changes upstream in https://github.com/ebrianne/duckdns-go)
Fixes #3