Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] move formats to submodule (#236) #301

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Conversation

ebroecker
Copy link
Owner

is this the way to restructure the formats to an own module?

@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #301 into development will decrease coverage by 0.79%.
The diff coverage is 86.11%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development     #301     +/-   ##
==============================================
- Coverage        38.12%   37.33%   -0.8%     
==============================================
  Files               34       34             
  Lines             6833     6833             
  Branches          1669     1669             
==============================================
- Hits              2605     2551     -54     
- Misses            4014     4067     +53     
- Partials           214      215      +1
Impacted Files Coverage Δ
src/canmatrix/formats/cmcsv.py 4.19% <ø> (ø)
src/canmatrix/formats/fibex.py 2.4% <ø> (ø)
src/canmatrix/formats/xls_common.py 3.33% <ø> (ø)
src/canmatrix/formats/xlsx.py 1.05% <ø> (ø)
src/canmatrix/formats/cmjson.py 67.22% <ø> (ø)
src/canmatrix/formats/kcd.py 1.78% <ø> (ø)
src/canmatrix/formats/arxml.py 11.37% <ø> (ø)
src/canmatrix/formats/dbf.py 1.94% <ø> (ø)
src/canmatrix/formats/dbc.py 50.39% <ø> (ø)
src/canmatrix/formats/sym.py 45.59% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8e53e...1376ab5. Read the comment docs.

@altendky
Copy link
Collaborator

I think so.

@ebroecker ebroecker merged commit 5a7f089 into development Feb 27, 2019
@ebroecker ebroecker deleted the formats_to_submodule branch March 29, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants