feat: prep separate directory for seeding with sims #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrovska-petro
requested review from
abdullah-almesbahi,
rayeaster,
sajanrajdev and
wtj2021
|
details on the requirements for each week can be found at: https://discord.com/channels/1011322803414388897/1218208598199500870/1219585892973281361 |
sajanrajdev
reviewed
Mar 21, 2024
sajanrajdev
reviewed
Mar 21, 2024
There was a problem hiding this comment.
Review
- Adds wsteth and reth to the repo, addresses confirmed
- Creates prep script to consolidate the treasury's rETH into stETH and create the pool (confirmed eBTC address)
- Creates scripts to seed the pool by batches with amounts according to treasury decision (left a comment)
- Adds simulations for the full cycle
Only comment is that once the CDP is created on week1, the following weeks should use the same CDP
sajanrajdev
reviewed
Mar 21, 2024
|
as discussed w/ @sajanrajdev we will split this pr into separate pr's. the focus on this one is uniquely the prep for swapping into the collateral and pool creation cmd: |
sajanrajdev
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Script was modified:
- Limits amount of rETH to be swapped for stETH to ~800 (uses CG's spot to estimate amount of rETH to add)
- Modifies the top-up portion of the script so that the original CDP is adjusted in order to borrow the eBTC required for the top-ups. It first tops-up collateral and then borrows more debt while preserving the target ICR (200%) - LGTM (Note: For the future, we should incorporate the
adjustCdpWithCollfunction so that we can do this two actions in one transaction). - Simulations show effective pool creation, eBTC borrowing and minting of positions (seeding) - LGTM
- Passing target ICR to function as 2e18 (200%) as expected by functions - LGTM
wtj2021
approved these changes
Mar 21, 2024
rayeaster
reviewed
Mar 22, 2024
| @@ -1582,9 +1582,7 @@ def cdp_withdraw_debt(self, cdp_id, debt_withdrawable_amount): | |||
| sync_tcr = self.cdp_manager.getSyncedTCR(feed_price) | |||
| assert sync_tcr > self.CCR | |||
|
|
|||
| # verify: existing debt in cdp id is greater than amount to wd | |||
| debt_before = self.cdp_manager.getCdpDebt(cdp_id) | |||
There was a problem hiding this comment.
might use cdp_manager.getSyncedCdpDebt() for debt_before
Merged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run sim: