-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wiring up steBTC governance #68
Conversation
wtj2021
commented
Sep 13, 2024
•
edited
Loading
edited
- adding 2 additional roles
- StakedEbtc: Donor (donate)
- StakedEbtc: Manager (setMintingFee, sweep, setMaxDistributionPerSecondPerAsset)
- assigning Donor role to fee_recipient_multisig
- assigning Manager role to ebtc_techops_multisig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adds two new gov roles focus in staking ebtc
- donate -> scope: only
donate(uint256)
✅ - general mgmt -> scope:
sweep(address)
,setMaxDistributionPerSecondPerAsset(uint256)
andsetMinRewardsPerPeriod(uint256)
✅
txs to be posted in the timelock batches the sets for the naming of each new role, capabilities/scope and finally the set user role
also adds test on the before/after state to ensure that after the delay of the timelock indeed new roles are configured properly ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds governance config of steBTC to the Governor contract (donor/manager role). Gives donor role to eBTC Fee recipient (makes sense as it is the receipient of the PYS). Gives manager access to TechOps, level of security makes sense at this stage.
Introduces test for the above.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.