Parameter & Variable Renames

[dapp-whisperer]

Covers some of the more complex / verbose changes listed in
#665

Goal:

• Consistency in use of coll, collShares, stEthBalances
• Consistency around eBTC and debt
  • Ebtc or ebtc when used in camelcase, as appropriate
  • eBTC, when used as the name of an asset
  • no more EBTC case in main code (tests are ok)
• And a few misc changes requested from Cantina cleanup

recoveryModeGracePeriod → recoveryModeGracePeriodDuration
GracePeriodSet → GracePeriodDurationSet

borrowerOperations.withdrawEBTC() → borrowerOperations.withdrawDebt()
borrowerOperations.repayEBTC() → borrowerOperations.repayDebt()

Many parameters

_EBTCAmount → _debt
_*EBTCChange → _debtChange*
_EBTC → _debt

*Redemption struct parameters changed for consistency and clarity

_requireSufficientEBTCBalance → _requireSufficientEbtcBalance
_requireValidEBTCRepayment → _requireValidDebtRepayment

_requireSufficientEbtcBalance(ebtcToken, msg.sender, debt)
_requireSufficientEbtcBalance(msg.sender, debt);

(don’t pass around immutables)

lastEBTCDebtErrorRedistribution → lastDebtRedistributionError

_requireEBTCBalanceCoversRedemptionAndWithinSupply → _requireEbtcBalanceCoversRedemptionAndWithinSupply

(also removed the ebtcToken address from parameter list, it’s a waste with immutables)

Bonus Features

• remove test-report.md
• remove liquity fuzzer folder

[rayeaster]

LGTM

add sequence liq related code removal for #679

[GalloDaSballo]

Have gone line by line and it looks fine

Tests are passing as well