Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use same calculation as CDPManager for CDP split fee in invariant test #799

Closed
wants to merge 1 commit into from

Conversation

rayeaster
Copy link
Contributor

  • use the same calculation for CDP fee split as in CDPManagerStorage.sol#getAccumulatedFeeSplitApplied()
  • compare the raw value in CDP before and after rebase

@getrecon-bot
Copy link

Job ID e6473295-6b50-4361-9ac0-e0af4f57ed4f
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 300000
Instance ID i-05ec76d62276c0a2b
Instance Type c5.2xlarge
Status Started
Elapsed

@getrecon-bot
Copy link

Job ID e6473295-6b50-4361-9ac0-e0af4f57ed4f
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 300000
Instance ID i-05ec76d62276c0a2b
Instance Type c5.2xlarge
Status Running
Elapsed 1 minute 18 seconds

@getrecon-bot
Copy link

Job ID e6473295-6b50-4361-9ac0-e0af4f57ed4f
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 300000
Instance ID i-05ec76d62276c0a2b
Instance Type c5.2xlarge
Status Running
Elapsed 1 minute 19 seconds

@getrecon-bot
Copy link

Job ID e6473295-6b50-4361-9ac0-e0af4f57ed4f
Command yarn && git submodule init && git submodule update && solc-select use 0.8.17 && cd packages/contracts/ && yarn echidna --test-mode assertion --test-limit 300000
Instance ID i-05ec76d62276c0a2b
Instance Type c5.2xlarge
Status Success
Elapsed 18 hours 6 minutes 18 seconds

@wtj2021 wtj2021 closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants