Chronicle oracle adapter #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalloDaSballo
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
The code for the adapter looks correct:
- Scales to oracle used by the eBTC Feed
- Checks for staleness
I'm not 100% confident that the optimistic Scribe oracle is as safe as the non optimistic version
This implementation will have a delay by nature as it needs to allow time for disputes, in contrast to the normal scribe oracle
I think we should monitor the onChain prices and see if the realised Deviation Threshold is above the advertised threshold due to the Optimistic Update delay
Also I highly recommend a E2E test on the eBTC Feed to ensure that the math checks out
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployed chronicle oracle https://etherscan.io/address/0x02238bb0085395ae52cd4755456891fc2fd5934d