Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing warm start and updating reference results for MCT #182

Open
wants to merge 10 commits into
base: feature/mct_optim
Choose a base branch
from

Conversation

ecCinziaMazzetti
Copy link
Contributor

Hi,
in this PR you have:

  • fixes to the warm start for kinematic, split and mct routing
  • updated reference results for mct, both quick and slow tests
  • fix to mct routing that prevents channels volume becoming negative when openwater and/or wateruse is in use

The following 'slow' tests were not run because reference results are no longer valid:

  • test_latlon
  • test_results
  • test_inflow
  • test_caching (I still have the old version with the bug)

For further information, see https://jira.smhi.tds.tieto.com/browse/EFCC-3975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant