re #432 provide better transfer api - implement estimate utility #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vide-better-api-for-transfer-estimation
…the estimate method The change creates a new type TransferProvider(similar to other provider types in taquito), which is made available in the TezosToolkit. TransferProvider implements only the estimate utility in this change. This change adds redundant estimate code, so that old estimate api can be removed easily. re #432
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
|
Thank you @skang404 for this WIP. I will close this PR for now, and revisit it with you in the near future. Will be in touch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tezos.estimate.transfer({})is also available asTezos.transfer({})._estimate()as a partial fix re #432 .Does not break the current code.
==========================================
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
Release Note Draft Snippet
Transfer API
A new API for making estimate for transfer requests has been added.