Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mk 566 update taquito website live code examples to edonet #687

Merged

Conversation

michaelkernaghan
Copy link
Collaborator

Updated test references and links to indicate edonet
changed the contract ids to work with edonet and still pass all the live code examples

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have added unit tests
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.
    CLOSE Update Taquito Docs website live code examples to use edonet #566

@michaelkernaghan michaelkernaghan added the documentation Improvements or additions to documentation label Mar 10, 2021
@michaelkernaghan michaelkernaghan self-assigned this Mar 10, 2021
@github-actions
Copy link

A new deploy preview is available on Netlify at https://a1e17980--tezostaquito.netlify.app

@github-actions
Copy link

A new deploy preview is available on Netlify at https://9343afda--tezostaquito.netlify.app

@codecov-io
Copy link

codecov-io commented Mar 10, 2021

Codecov Report

Merging #687 (6f549c4) into master (7b424b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #687   +/-   ##
=======================================
  Coverage   80.58%   80.58%           
=======================================
  Files         137      137           
  Lines        7421     7421           
  Branches     1916     1916           
=======================================
  Hits         5980     5980           
  Misses       1436     1436           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b424b6...6f549c4. Read the comment docs.

@github-actions
Copy link

A new deploy preview is available on Netlify at https://458306b8--tezostaquito.netlify.app

@michaelkernaghan
Copy link
Collaborator Author

michaelkernaghan commented Mar 11, 2021

Here is the test result after walking through all the links on a preview build: https://ecadlabs.ontestpad.com/script/101/report/?auth=e07829f6317168e912b29d9d8a208160
in the last run, there was 1 remaining broken link, which I have fixed prior to pushing this merge.

There are a couple of oddball situations with two wallet live code examples - TBD but not critical.

@michaelkernaghan
Copy link
Collaborator Author

For automation, each contract origination required can be done with Taquito. Most of the scripts can be taken directly from integration tests.

The other editing required on a protocol change is replacing names; this can be done quickly enough by hand it's not worth scripting.

@github-actions
Copy link

A new deploy preview is available on Netlify at https://a151dfc0--tezostaquito.netlify.app

@github-actions
Copy link

A new deploy preview is available on Netlify at https://98f9b038--tezostaquito.netlify.app

Copy link
Collaborator

@jevonearth jevonearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jevonearth jevonearth merged commit a097ad5 into master Mar 12, 2021
@jevonearth jevonearth deleted the mk-566-update-taquito-website-live-code-examples-to-edonet branch March 12, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Taquito Docs website live code examples to use edonet
4 participants