Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast forward workflow always blocked #3135

Closed
usu opened this issue Nov 5, 2022 · 1 comment
Closed

Fast forward workflow always blocked #3135

usu opened this issue Nov 5, 2022 · 1 comment

Comments

@usu
Copy link
Member

usu commented Nov 5, 2022 •
edited
Loading

I'm opening a new issue to avoid the comments being buried within the various alpha deployment pull requests.

I didn't success to make it run. What I checked so far

  • All relevant organization and repo settings seem to be the same between ecamp and bacluc-test-org
  • The API response within the workflow and the response when hitting the API manually is in many cases different
  • I was able to reproduce this on bacluc-test-org. In many cases, querying the API manually got me "pending" while the workflow said "blocked"
  • However, on bacluc-test-org the final run after all tests passed always succeeds

Caching
Cached responses could theoretically be a cause. There are discussion and solutions about this on octokit repo (which is utilized by actions/github-script). I don't think server/API cache is the issue, though. The comments property which counts the number of comments on the pull request was consistently increasing.
octokit/octokit.js#890 (comment)
pascalgn/automerge-action#122 (comment)

Other hypotheses:

  1. The user that queries the API always receives blocked for some reason.
  2. The workflow temporarily sets the pull request to blocked
  3. A bug in GitHub API on an undocumented API property

1. The user that queries the API always receives blocked for some reason.
I would have guessed, the API call is being done by the user who triggers the workflow which is the user who leaves the comment in the pull request. Didn't debug further.

2. The workflow temporarily sets the pull request to blocked
I tried to query the API manually while the workflow is running. Couldn't confirm this so far, unless the change in status is happening for a very short time.

3. A bug in GitHub API on an undocumented API property
This hypothesis would be supported by the fact that other users are struggling with mergeable_state:
pascalgn/automerge-action#122
pascalgn/automerge-action#103
Expensify/App#9625
@usu usu mentioned this issue Nov 5, 2022
Merged
BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Nov 5, 2022
@BacLuc
ci: use FAST_FORWARD_TOKEN to query api in fast-forward.yml
bd101ba 
Without that it did not work on the test-org.
See https://github.com/bacluc-test-org/ecamp3/blob/64fa2aeec519ad9b6a9d62c218e68aa31a87383a/.github/workflows/fast-forward.yml#L35

Issue: ecamp#3135
@BacLuc BacLuc mentioned this issue Nov 5, 2022
Merged
@BacLuc
Copy link
Contributor

BacLuc commented Jul 29, 2023

This seems to work better now.
Can we close this issue?

@BacLuc BacLuc closed this as completed Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@usu @BacLuc