Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document trusted oauth providers #4833

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Document trusted oauth providers #4833

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
891267c
Document trusted oauth providers
simfeld Mar 26, 2024
23c0a8d
Fix trailing space
simfeld Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions api/src/Entity/Profile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ class Profile extends BaseEntity {
#[ORM\Column(type: 'string', length: 255, nullable: true)]
public ?string $untrustedEmailKeyHash = null;

// ========================= start trusted Oauth provider ids =========================
// Note: as of https://github.com/ecamp/ecamp3/pull/4779 we are assuming that email
// addresses received from Oauth providers are trusted in the sense that email ownership has
// previously been verified by the corresponding service. When adding more providers, either
// - validate this assumption for the new provider, or
// - remove the logic setting the user state to active for existing non-activated user profiles
// in the new authenticator implementation (api/src/Security/OAuth/*Authenticator.php)

/**
* Google id of the user.
*/
Expand Down Expand Up @@ -119,6 +127,8 @@ class Profile extends BaseEntity {
#[ORM\Column(type: 'string', length: 255, nullable: true)]
public ?string $jubladbId = null;

// ========================= end trusted Oauth provider ids =========================

/**
* The user's (optional) first name.
*/
Expand Down
Loading