fix xls sheet name length #7901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That we can test it in isolation.
And replace the last 3 chars with random alphanumeric characters on collision. This also fixes the "duplicate sheet" error if 2 periods have the same name.
simfeld
approved these changes
Aug 3, 2025
|
|
||
| const workbook = toWorkbook(sheets) | ||
|
|
||
| expect(workbook.SheetNames).toEqual([sheetName.slice(0, 31)]) |
Contributor
There was a problem hiding this comment.
you are plus ou moin testing that slice does what it does, so maybe use 'a'.repeat(31)?
| expect(workbook.SheetNames).toEqual([sheetName.slice(0, 31)]) | ||
| }) | ||
|
|
||
| it('does not overwrite sheets when shortening them makes them not unique anymore', () => { |
Contributor
There was a problem hiding this comment.
I tripped over this test name because I assumed overwrite means changing the sheet name, but you mean it doesn't replace the first one with the same (resulting) name. Maybe "does not drop sheets ..."?
Contributor
Author
There was a problem hiding this comment.
It's not dropping, its replacing the pointer in the map. I would call that overwriting, but i am open for better formulations.
pmattmann
reviewed
Aug 3, 2025
| const validSheetName = sheetName.replaceAll(/[?*[\]/\\:]/g, '') | ||
| let slicedSheetName = validSheetName.slice(0, 31) | ||
| if (workbook.SheetNames.includes(slicedSheetName)) { | ||
| slicedSheetName = validSheetName.slice(0, 28) + randomString(3) |
Member
There was a problem hiding this comment.
Why are you using a random string here?
Wouldn't a simple increment be more understandable?
Like:
MeinLangerPeriodeNam001
MeinLangerPeriodeNam002
...
Contributor
Author
|
I considered 4 possible fixes:
We can pick our poison. I picked number 4. |
pmattmann
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frontend: extract method toWorkbook in useMaterialViewHelper.js
That we can test it in isolation.
frontend: trim sheetNames to 31 chars in useMaterialViewHelper.js
And replace the last 3 chars with random alphanumeric characters
on collision.
This also fixes the "duplicate sheet" error if 2 periods have the same name.
Closes: #7184