Skip to content

Improve generated pdf names #7996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2025
Merged

Improve generated pdf names #7996

merged 1 commit into from
Aug 23, 2025
+6 −3

Conversation

@carlobeltrame
Copy link
Member

@carlobeltrame carlobeltrame commented Aug 17, 2025 •
edited
Loading

PDF export PDF filename before this PR (example) PDF filename after this PR (example) Comment
Activity detail Stadtgame-pdf.pdf Stadtgame.pdf removed duplicate pdf extension
Story overview GRGR-StorySummary-pdf.pdf PfiLa-2023-Geschichte.pdf changed to short title, removed duplicate pdf extension, replaced english term by translated term
Picasso GRGR-picasso-pdf.pdf PfiLa-2023-Hauptlager.pdf changed to short title, removed duplicate pdf extension, replaced generic english term by period description
Print configurator PfiLa-2023.pdf PfiLa-2023.pdf unchanged

The .pdf extension is added later in the generatePDFMixins, so we don't need to add it to the initial value of documentName.

@carlobeltrame carlobeltrame requested a review from a team August 17, 2025 14:02
@carlobeltrame carlobeltrame added the deploy! Creates a feature branch deployment for this PR label Aug 17, 2025
@github-actions
Copy link

github-actions bot commented Aug 17, 2025 •
edited
Loading

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@carlobeltrame carlobeltrame force-pushed the improve-pdf-filenames branch from cea7a4a to 7a801aa Compare August 18, 2025 06:50
@pmattmann pmattmann requested a review from a team August 21, 2025 18:24
@carlobeltrame carlobeltrame added this pull request to the merge queue Aug 23, 2025
Merged via the queue into ecamp:devel with commit 485db77 Aug 23, 2025
30 checks passed
@carlobeltrame carlobeltrame deleted the improve-pdf-filenames branch August 23, 2025 11:37
@BacLuc BacLuc mentioned this pull request Sep 2, 2025
Merged
@github-actions github-actions bot mentioned this pull request Sep 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmattmann pmattmann pmattmann approved these changes

@BacLuc BacLuc BacLuc approved these changes

Assignees

No one assigned

Labels

deploy! Creates a feature branch deployment for this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlobeltrame @pmattmann @BacLuc