Skip to content

Conversation

@BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Aug 31, 2025

This is recommended in their templates.
For that we need to use another Error class, the one used to create ValidationError was in the core library. Like this we don't depend on e.g. the ODM part.
And we can move the graphql part to require-dev,
because we don't want to activate this in prod yet.

@BacLuc BacLuc requested a review from a team August 31, 2025 16:32
This is recommended in their templates.
For that we need to use another Error class, the one
used to create ValidationError was in the core library.
Lite this we don't depend on e.g. the ODM part.
And we can move the graphql part to require-dev,
because we don't want to activate this in prod yet.
@BacLuc BacLuc force-pushed the split-apiplatform-dependencies branch from 12176f9 to 514d1e4 Compare August 31, 2025 16:36
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be fine as long as CI is green

@BacLuc BacLuc requested a review from a team August 31, 2025 19:03
@BacLuc BacLuc added this pull request to the merge queue Sep 2, 2025
Merged via the queue into ecamp:devel with commit ad15f6a Sep 2, 2025
30 checks passed
@BacLuc BacLuc deleted the split-apiplatform-dependencies branch September 2, 2025 18:24
@BacLuc BacLuc mentioned this pull request Sep 2, 2025
@github-actions github-actions bot mentioned this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants