Skip to content

EAutocomplete: Support multiple highlighted items in search text #8080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 3, 2025
Merged

EAutocomplete: Support multiple highlighted items in search text #8080

merged 8 commits into from
Oct 3, 2025

Conversation

@pmattmann
Copy link
Member

@pmattmann pmattmann commented Sep 2, 2025

image

@pmattmann pmattmann requested a review from a team September 2, 2025 22:47
@pmattmann pmattmann marked this pull request as draft September 3, 2025 04:55
carlobeltrame
carlobeltrame reviewed Sep 4, 2025
View reviewed changes
@pmattmann pmattmann added the deploy! Creates a feature branch deployment for this PR label Sep 4, 2025
@github-actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited
Loading

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@pmattmann pmattmann marked this pull request as ready for review September 4, 2025 20:14
BacLuc
BacLuc reviewed Sep 5, 2025
View reviewed changes
manuelmeister
manuelmeister requested changes Sep 5, 2025
View reviewed changes
Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha, I knew the moment you asked this in the core meeting that you are going to solve this :D. Nice!

@pmattmann pmattmann removed the deploy! Creates a feature branch deployment for this PR label Sep 6, 2025
@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label Sep 6, 2025
@BacLuc BacLuc added deploy! Creates a feature branch deployment for this PR and removed deploy! Creates a feature branch deployment for this PR labels Sep 6, 2025
manuelmeister
manuelmeister approved these changes Sep 6, 2025
View reviewed changes
Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to add a 7.5kb dependency for this feature, but it works!

carlobeltrame
carlobeltrame reviewed Sep 7, 2025
View reviewed changes
frontend/src/components/form/base/EAutocomplete.vue
if (info) {
return uFuzzy.highlight(
item.text,
info.ranges[0],
Copy link
Member

@carlobeltrame carlobeltrame Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean only the first occurrence of each match is highlighted?

Copy link
Member Author

@pmattmann pmattmann Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the library can process multi-line text.
Here, info.ranges[0] means that only the hits of the first line are highlighted.

@pmattmann pmattmann added this pull request to the merge queue Oct 3, 2025
Merged via the queue into ecamp:devel with commit f2d575c Oct 3, 2025
74 of 76 checks passed
@pmattmann pmattmann deleted the feature/autocomplete-multiple-items branch October 3, 2025 18:50
This was referenced Oct 3, 2025
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BacLuc BacLuc BacLuc approved these changes

@manuelmeister manuelmeister manuelmeister approved these changes

@carlobeltrame carlobeltrame carlobeltrame approved these changes

Assignees

No one assigned

Labels

before-vue3 deploy! Creates a feature branch deployment for this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pmattmann @BacLuc @manuelmeister @carlobeltrame