Skip to content

Conversation

@carlobeltrame
Copy link
Member

@carlobeltrame carlobeltrame commented Sep 17, 2025

There has been a series of attacks on npm packages recently:
https://decipher.sc/2025/09/08/targeted-attack-compromises-popular-npm-packages/
https://www.aikido.dev/blog/s1ngularity-nx-attackers-strike-again

This leads to compromising the machines of devs, and from there automatically infects npm packages to which the dev (or CI pipeline) has publishing access, or GitHub push access. This commit is a band-aid quick fix, so we don't install the bleeding edge new package the minute it comes out. So far, package maintainers and NPM have been relatively quick to find and yank the infected packages. This is not guaranteed to protect us, but it should make it harder for us to automatically get infected.

For reference, the renovate docs on this option:
https://docs.renovatebot.com/configuration-options/#minimumreleaseage

There has been a series of attacks on npm packages recently:
https://decipher.sc/2025/09/08/targeted-attack-compromises-popular-npm-packages/
https://www.aikido.dev/blog/s1ngularity-nx-attackers-strike-again

This leads to compromising the machines of devs, and from there automatically infects npm packages to which the dev (or CI pipeline) has publishing access, or GitHub push access.
This commit is a band-aid quick fix, so we don't install the bleeding edge new package the minute it comes out. So far, package maintainers and NPM have been relatively quick to find and yank the infected packages. This is not guaranteed to protect us, but it should make it harder for us to automatically get infected.

For reference, the renovate docs on this option: https://docs.renovatebot.com/configuration-options/#minimumreleaseage
@carlobeltrame carlobeltrame requested a review from a team September 17, 2025 08:45
},
"automergeType": "branch",
"rebaseWhen": "conflicted",
"minimumReleaseAge": "7 days",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just as info: this is for everything, not just npm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for bringing it up. This is more or less on purpose. Even though the recent breaches have been on npm, other package managers and registries are not immune to such attacks.

@carlobeltrame carlobeltrame requested a review from a team September 17, 2025 14:38
@simfeld simfeld added this pull request to the merge queue Sep 17, 2025
Merged via the queue into devel with commit 93c80f9 Sep 17, 2025
50 checks passed
@simfeld simfeld deleted the renovate-minimum-release-age branch September 17, 2025 18:13
This was referenced Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants