Add typing to v3 #300
Merged
Add typing to v3 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmeister
force-pushed
the
feature/remove-cjs
branch
7 times, most recently
from
802e37a to
bd6ed4a
Compare
Merged
manuelmeister
force-pushed
the
feature/remove-cjs
branch
from
bd6ed4a to
b04b384
Compare
BacLuc
reviewed
Sep 9, 2024
src/Collection.ts
Outdated
| return array | ||
| .filter(entry => isEntityReference(entry)) | ||
| .map(entry => this.apiActions.get(entry.href)) | ||
| private _replaceEntityReferences (array: Array<ItemType>): Array<ItemType> { |
There was a problem hiding this comment.
Is not from your change, but this method is dangerous: if filters out the items which are not Link, and removes them silently from the collection
There was a problem hiding this comment.
Can you create an Issue to maybe warn the user?
simfeld
reviewed
Sep 28, 2024
manuelmeister
force-pushed
the
feature/remove-cjs
branch
from
8375d38 to
a5577fe
Compare
simfeld
approved these changes
Sep 28, 2024
manuelmeister
force-pushed
the
feature/remove-cjs
branch
from
f58f887 to
b7c6da4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds typing to hal-json-vuex