Refactor[issuer.find]: Rename to find_with_token

ecaresoft · Mar 25, 2017 · 4615991 · 4615991
1 parent c26bb24
commit 4615991
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/ditto/issuer.rb b/lib/ditto/issuer.rb
@@ -25,7 +25,7 @@ def save
     client.refresh_token = key
   end
 
-  def self.find(id, token)
+  def self.find_with_token(id, token)
     client = Ditto::Client.new
     attrs = client.get("SearchEmisorById/#{id}?Token=#{token}")
     new(attrs)

diff --git a/spec/ditto/issuer_spec.rb b/spec/ditto/issuer_spec.rb
@@ -53,24 +53,24 @@
 
   describe '#find' do
     it 'fails to find an issuer with wrong token', :vcr do
-      expect { Ditto::Issuer.find('123', 'meep') }.to raise_error(Faraday::ClientError)
+      expect { Ditto::Issuer.find_with_token('123', 'meep') }.to raise_error(Faraday::ClientError)
     end
 
     it 'fails to find an unknown issuer', :vcr do
       issuer1 = Ditto::Issuer.create(attributes)
-      expect { Ditto::Issuer.find('123', issuer1.token) }.to raise_error(Faraday::ClientError)
+      expect { Ditto::Issuer.find_with_token('123', issuer1.token) }.to raise_error(Faraday::ClientError)
     end
 
     it 'succeed to find same issuer', :vcr do
       issuer1 = Ditto::Issuer.create(attributes)
-      issuer2 = Ditto::Issuer.find(issuer1.id, issuer1.token)
+      issuer2 = Ditto::Issuer.find_with_token(issuer1.id, issuer1.token)
       expect(issuer2.id).to eq(issuer1.id)
     end
 
     it 'succeed to find different issuer', :vcr do
       issuer1 = Ditto::Issuer.create(attributes)
       issuer2 = Ditto::Issuer.create(attributes)
-      issuer3 = Ditto::Issuer.find(issuer1.id, issuer2.token)
+      issuer3 = Ditto::Issuer.find_with_token(issuer1.id, issuer2.token)
       expect(issuer3.id).to eq(issuer1.id)
       expect(issuer3.id).to_not eq(issuer2.id)
     end