Refactor de componente Java #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Se cambia el nombre de la clase X_Tax por XTax para mantener mismo formato
Se elimina el codigo que no se utiliza. NOTA: Esto se hace suponiendo que el codigo no aporta utilidad para cumplir los requerimientos de la aplicación ya que desconozco los mismos.
Se separa la funcionalidad de validate en 2 funciones. La getIds obtiene los ID's, y la validateIds los valida.
Cambio en la posición en que se declaran las listas de errores e ID's para solo crearlas en caso de que existan elementos en xTaxList.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modificaciones realizadas:
Pendientes: