Ecaresoft Java Code Refactoring #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change the class name (X_Tax -> XTax) according to java conventions.
* Change the name and getter and setter methods of some attributes
in order to use the same language in the class:
- tasaOCuota -> fee
- trasladado -> transferred
* Change the support class (X_Tax.java -> XTax.java).
* Change the name of the method (validate -> validateTaxes) to make it more readable.
* Change the error messages to english.
* Clean the commented code to use only the necessary code.
* Avoid unecessary if - else statement validating if the xTaxList is null or not.
* Change the logic to set the Tax Created Date:
- Write the record directly if the tax has and Id instead of creating a String list to loop it after
validations making a XTax list again using the strings to make a HasMap collection to loop
it by index to write it finally.
* Change the logic with the variable cont to validate if there non-local taxes.
Instead it is implemented the bool variable 'noLocalTax' which is only true if even once there
is a non-local tax.
* Add comments in each if statement.
* Indentation Adjusting.
benoror
requested review from
adeluna,
AdriCabSan,
AnaidLozaCerda,
cvazquezecare,
Gnikangel,
KikeRdz and
lorenalama
and removed request for
AnaidLozaCerda and
KikeRdz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in file X_Tax.java:
Changes in file Readme.md:
Changes in file MTax.java
Write the record directly if the tax has and Id instead of creating a String list to loop it after
validations making a XTax list again using the strings to make a HasMap collection to loop
it by index to write it finally.