Ruby Controller Refactor #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it more readable Originally the file has 2 spaces as indentation. Now, the file has 4 spaces as indentation according to the ruby conventions.
… it more readable
… code reading * Movement in the order of the methods in order to organizate it by calling. * Add method docstrings in the controller methods to identify the functionality and the return data more easy. * Require and include the CalendarTimeCalculation module in the controler.
OscarCordova
force-pushed
the
ecs_ruby_test
branch
from
9020f20
to
28c158e
Compare
benoror
requested review from
JorgeGarciaxyz,
AnaidLozaCerda,
jvann and
KikeRdz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in file calendar_time_calculation.rb:
Changes in file available_hours_controller.rb:
Improve code indentation to make it more readable.
Movement in the order of the methods in order to organizate it by calling.
Add method docstrings in the controller methods to identify the functionality and the return data more easy.
Require and include the CalendarTimeCalculation module in the controler.