New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AvailableHoursController and CalendarTimeCalculation #32

Open

diegoaleman wants to merge 3 commits into ecaresoft:master from diegoaleman:master

diegoaleman commented Feb 22, 2019

AvailableHoursController

refactor the logic inside the index method
- main logic now at available_schedules
- create private methods for frequently used CalendarTimeCalculation calls
- use schedule_ends variable to make conditional easier to read
fix line that exceeded 80 chars

CalendarTimeCalculation

fix line that exceeded 80 chars

**Apologies for the indentation error on the first two commits. My terminal was configured incorrectly. Issue is now fixed.

diegoaleman added 3 commits

February 21, 2019 15:54


          Refactor of available schedule functionality at index method

fa43b90


          Fix lines longer than 80 and fix end indentation of AvailableHoursCon…

c8d319d

…troller class


          Indentation fix, incorrect number of spaces used

aeb08a4

elitorresr requested a review from JorgeGarciaxyz

February 25, 2019 16:56

Contributor

JorgeGarciaxyz commented Feb 26, 2019

Nice! Está bien, te vamos a mandar un correo para la segunda parte de la prueba 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet