Refactor[]:Change position of code, add of comments and correction in… #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… names of functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor de componentes + Optimization de partes del código.
*Se movieron las declaraciones a la parte superior del codigo
*Se agregaron comentarios descriptivos en el código.
*Se elimino código comentado poco comprensible o sin funcionalidad.
-Llamada de una función que no existía (MInfoTaxCategory.getTaxCategoryStringList()). No se encontraba dentro de la clase x_Tax
*Se modifico código comentado con nombre de funciones incorrectos (getTaxAmount por getAmount). Este se comparó con las funciones dentro de clase x_Tax
*Se elimino el if(!tax.islocal) pues dentro del Else correspondiente a if(isLocal()) se podía hacer la suma al contador Cont++