This repository has been archived by the owner on May 25, 2022. It is now read-only.
Add Javascript #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luissifu
force-pushed
the
draft/javascript
branch
from
60c1eb9
to
63b5fc3
Compare
jvann
suggested changes
Dec 2, 2019
|
|
||
| ### Useful Links | ||
| Styleguide | ||
| * [Javascript styleguide](styleguide.md) |
There was a problem hiding this comment.
Esto a donde tiene que llevar? Me lleva a un 404 not found (https://github.com/ecaresoft/guides/blob/60c1eb9ad40433549cb9c9e2779478b6327c4c09/javascript/javascript/styleguide.md)
Comment on lines
+72
to
+79
| const membershipGoldStub = Service.extend({ | ||
| hasLite: false | ||
| }); | ||
|
|
||
| test('render lock when template is locked for basic user', function(assert) { | ||
| this.container.registry.register('service:mockMembership', membershipBasicStub); | ||
| // ... | ||
| }); |
There was a problem hiding this comment.
Mocking wrong stub membershipGoldStub -> membershipBasicStub please change to basic or gold stub 👍
| Source: [Apollo](https://github.com/ecaresoft/apollo/blob/master/app/pods/login/controller.js) | ||
|
|
||
| While classes are similar to the other languages, most it's important to understand what the | ||
| keywords `import`, `export, and `default` do. |
|
|
||
| ## Semicolons | ||
|
|
||
| + Use semicolons`;` |
|
|
||
| ## Comments | ||
|
|
||
| + Pad comments with a space. |
There was a problem hiding this comment.
Maybe explain when to use comments as well?
| // good | ||
| const isTrue = true; | ||
| const bar = 123; | ||
| let foo; |
There was a problem hiding this comment.
Maybe add newline between const and let group?
| // good | ||
| foo[propertyName]; | ||
|
|
||
| // do you even javascript |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for javascript, including a styleguide and a introduction.
Review using: https://github.com/ecaresoft/guides/tree/60c1eb9ad40433549cb9c9e2779478b6327c4c09