Fix: Sidebar content invisible in light mode#131
Open
anjaliushadubey wants to merge 4 commits intoeccentriccoder01:masterfrom
Open
Fix: Sidebar content invisible in light mode#131anjaliushadubey wants to merge 4 commits intoeccentriccoder01:masterfrom
anjaliushadubey wants to merge 4 commits intoeccentriccoder01:masterfrom
Conversation
Thanks for creating a PR for your Issue!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #122
Rationale for this change
This change is necessary to fix a significant accessibility and usability bug in the application's light mode. The sidebar content was using a text color that was indistinguishable from the background color (likely white-on-white), rendering essential navigational elements invisible to the user. This fix ensures that all content is clearly visible regardless of the user's selected theme.
What changes are included in this PR?
This PR includes a modification to the styling for the sidebar component. Specifically, the CSS property responsible for the text color within the sidebar has been adjusted for the light mode theme. This update corrects the contrast issue by ensuring the text uses a dark primary color against the light background.
Are these changes tested?
Yes, these changes have been manually tested. I have verified the following:
Light Mode: Sidebar content is now clearly visible and readable.
Dark Mode: Existing dark mode styling is unaffected, and content remains visible.
Are there any user-facing changes?
Yes. This is a positive user-facing change. Users who use the application in light mode will now be able to see and interact with the sidebar content, which was previously invisible to them.
Before
After
