Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mapSource invocation #45

Merged
merged 2 commits into from
Nov 6, 2018
Merged

Fix mapSource invocation #45

merged 2 commits into from
Nov 6, 2018

Conversation

helospark
Copy link

PR for #44

What

  • Moved out the mapSource to a central util to avoid code duplication
  • Queried the method before calling it instead of relying on exceptions
  • Added fail fast in case of the correct method is not found to ease later debugging efforts
  • In JDT there is two overloaded methods with this name, but they are telescopic, and just pass null if the additional parameter are not filled. I followed the same principle to simplify the code.

Why

mapSource signature was changed in Eclipse Photon, however the invocation was still calling with the previous signature and did not fallback to the correct signature. This caused at least that: breakpoints cannot be set in decompiled classes, info is not shown for variables in decompiled class.

Please review, also let me know, if there are tests somewhere, which I have missed.

@RobertZenz RobertZenz self-requested a review August 20, 2018 22:16
@RobertZenz RobertZenz self-assigned this Nov 6, 2018
@RobertZenz RobertZenz added this to the 3.1.1 milestone Nov 6, 2018
@RobertZenz RobertZenz added the bug label Nov 6, 2018
@RobertZenz RobertZenz merged commit 49f7192 into ecd-plugin:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants