Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

134 broke all my devices... #95

Closed
disruptivepatternmaterial opened this issue May 10, 2024 · 5 comments · Fixed by #96
Closed

134 broke all my devices... #95

disruptivepatternmaterial opened this issue May 10, 2024 · 5 comments · Fixed by #96
Assignees

Comments

@disruptivepatternmaterial
Copy link
Collaborator

...I had to revert back to 133, not sure why, it is midnight here and need to get some sleep :) but something is up!

@echavet
Copy link
Owner

echavet commented May 10, 2024

Oh sh...!!

@echavet
Copy link
Owner

echavet commented May 10, 2024

@disruptivepatternmaterial,
as soon as possible, could you tell me more about that?
I don't understand what could happen because the difference between 1.3.3 ans 1.3.4 is just about vaneMap and wideVaneMap constants: https://github.com/echavet/MitsubishiCN105ESPHome/compare/v1.3.3...v1.3.4?diff=split&w=
I'd like to fix the pb ASAP if it's so bad.

@echavet echavet self-assigned this May 10, 2024
echavet added a commit that referenced this issue May 10, 2024
@echavet
Copy link
Owner

echavet commented May 10, 2024

ok I think it is fixed on v1.3.4b
sorry for that

@disruptivepatternmaterial
Copy link
Collaborator Author

HAHAH yes sorry about that I wanted to post something before I went to bed. I am a tad clueless as to what the issue was because 2 of them eventually came back, but 2 required me to remove it and flash it from the usb. Let me try out what you have now and see what I find :)

@echavet
Copy link
Owner

echavet commented May 12, 2024

HAHAH yes sorry about that I wanted to post something before I went to bed. I am a tad clueless as to what the issue was because 2 of them eventually came back, but 2 required me to remove it and flash it from the usb. Let me try out what you have now and see what I find :)

😂
I think it was a (nullptr) side effect of my attempt to fix an issue about widevane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants