Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): generate prisma client before nexus types #25

Merged
merged 1 commit into from
Aug 18, 2020
Merged

fix(cli): generate prisma client before nexus types #25

merged 1 commit into from
Aug 18, 2020

Conversation

cball
Copy link
Member

@cball cball commented Aug 18, 2020

This prevents an error on installation. We need to generate Prisma types before we try and generate anything with Nexus.

Changes

  • Adds "Generate Prisma client" step

Screenshots

image

Checklist

  • Requires dependency update?
  • Generating a new app works

Fixes #24

ryanpatk
ryanpatk approved these changes Aug 18, 2020
View reviewed changes
Copy link

@ryanpatk ryanpatk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

@cball cball merged commit 7315d0f into master Aug 18, 2020
@cball cball deleted the 24-generate-prisma-before-nexus branch August 18, 2020 19:30
@github-actions
Copy link

🎉 This PR is included in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Issue has been included in a PR label Aug 18, 2020
cball added a commit that referenced this pull request Aug 20, 2020
@cball
fix(cli): generate prisma client before nexus types (#25)
d9e793b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanpatk ryanpatk ryanpatk approved these changes

Assignees
No one assigned
Labels
released Issue has been included in a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation fails at "Generate Nexus types"
2 participants
@cball @ryanpatk