feat: generate the db url based on the .env DATABASE_URL #34
Conversation
isaiahgrey93
force-pushed
the
isaiahgrey93/generate-test-db-url-based-on-env-url
branch
from
915206c
to
2a1c40b
Compare
…ting the path + schema param
isaiahgrey93
force-pushed
the
isaiahgrey93/generate-test-db-url-based-on-env-url
branch
from
72bb1de
to
60f001e
Compare
| const testDatabaseName = 'testing'; | ||
| const testSchema = `test_${nanoid().toLowerCase()}`; | ||
| const testDatabaseUrl = new URL(process.env.DATABASE_URL); | ||
| testDatabaseUrl.pathname = `/${testDatabaseName}`; |
There was a problem hiding this comment.
Do we need to modify the database used @cball? Or will the different schema suffice?
There was a problem hiding this comment.
The only potential downside I can think of here is if someone creates a postgres user that is not a super user or does not have create schema permissions.
We either need to require that the postgres user has the right permissions, or we should take DATABASE_URL wholesale if defined.
I'm leaning towards requiring a postgres user with the right permissions and keeping the auto generated schema. what do you think?
There was a problem hiding this comment.
Yeah I'm there with you on requiring the user with the right permissions vs using the existing dev database which might lead to test issues.
Should we document how to do this, or simply mention that the postgres user needs x permissions or is a super user?
There was a problem hiding this comment.
Cool.
We should probably add to the docs (probably in getting started). Something like "When setting up postgres locally, we recommend creating a superuser to keep things easy, but if you'd like to change it just ensure the user has create schema permission."
isaiahgrey93
deleted the
isaiahgrey93/generate-test-db-url-based-on-env-url
branch
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…ting the path + schema param (#34)
Changes
URLScreenshots
(prefer animated gif)
Checklist
Fixes #19