Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

an/destination and template api keys #16

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ashnel
Copy link
Contributor

@ashnel ashnel commented Jun 30, 2020

Changes

  • Add logo to login screen
  • Change logout container to menu container
    • Add keys navigation
  • Remove keys management from clubhouse controller
  • Add new keys controller
  • Add new keys view
    • Add template key
    • Delete template key
    • Add destination key
    • Delete destination key
  • Migrations for adding template and destination key fields to user
  • Bug fix for forgotten case: app crashed if not authorized with Clubhouse since there was no way to grab a user's Clubhouse projects

To Do

  • Sidekiq jobs originally relied on getting template key from env
    • Need to fix jobs to pull key from user data, story generation broken until this is complete

@@ -254,7 +254,7 @@
# config.navigational_formats = ['*/*', :html]

# The default HTTP method used to sign out a resource. Default is :delete.
config.sign_out_via = :delete
config.sign_out_via = :get
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change because for some reason I kept getting an error even though my logout button was using the :delete method. I'm not sure why it thinks it was :get but this was the only way around. I'm not confident this is the right change but I had to make it so the app would stop breaking.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant