Skip to content
This repository was archived by the owner on Mar 8, 2023. It is now read-only.

Enable mountd_port parameter for Red Hat. #35

Merged
merged 3 commits into from
Sep 22, 2015
Merged

Enable mountd_port parameter for Red Hat. #35

merged 3 commits into from
Sep 22, 2015

Conversation

rnelson0
Copy link

No description provided.

ensure => present,
target => '/etc/sysconfig/nfs',
variable => 'MOUNTD_PORT',
value => "${mountd_port}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifests/server/redhat.pp - WARNING: string containing only a variable on line 25

Thats a reason why travis CI shows an error.

@rnelson0
Copy link
Author

Fixed the issue on line 25.

Aside: .gitignore doesn't include Gemfile.lock. Do you want me to include that in this PR in the same or separate commit or fix it in a separate PR?

@dwerder
Copy link
Member

dwerder commented Sep 22, 2015

You can add it to this PR. Thanks

  Add operatingsystemmajrelease fact to rspec-puppet for future parser
  Test that operatingsystemmajrelease is defined first
@rnelson0
Copy link
Author

@dwerder Whew, I think I abused TravisCI enough to discover the fix to the future parser issues and such. This should be ready for review/merge now!

dwerder added a commit that referenced this pull request Sep 22, 2015
Enable mountd_port parameter for Red Hat.
@dwerder dwerder merged commit d8a0517 into echocat:master Sep 22, 2015
@rnelson0
Copy link
Author

@dwerder Thanks! What's the timeframe for releasing a new version on the forge? Just need to know when I can modify the Puppetfile back to the forge ref.

@dwerder
Copy link
Member

dwerder commented Sep 22, 2015

I will try to release it next week. I am on vacation at the moment ;)

@rnelson0
Copy link
Author

Bad Daniel! :) Enjoy your vacation, I'll point to github for now.

Rob Nelson

@rnelson0
Copy link
Author

Bad Daniel! Enjoy your vacation, I'll point to github for now :)

Rob Nelson
rnelson0@gmail.com

On Tue, Sep 22, 2015 at 11:56 AM, Daniel Werdermann <
notifications@github.com> wrote:

I will trey to release it next week. I am on vacation at the moment ;)


Reply to this email directly or view it on GitHub
#35 (comment).

@rnelson0 rnelson0 deleted the redhat_mountd branch September 22, 2015 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants