-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable sip pyi generated #3
base: master
Are you sure you want to change the base?
Conversation
I like this proposal more than the one from here as it seems much more complete. I tested this briefly and noticed the following points: 1. Missing Constants 2. Some methods not found 3. Some functions are not correctly typed: 4. Setter of class Window(WindowBase):
...
@property
def Size(self) -> Size: ...
@Size.setter
def Size(self, x: int, y: int, width: int, height: int, sizeFlags: int = ...) -> None: ...
... But they have to have only one argument like this: class Window(WindowBase):
...
@property
def Size(self) -> Size: ...
@Size.setter
def Size(self, val: Size) -> None: ...
... 4. Missing documentation |
My goal here wasn't to replace the ones already there by the PI generator, but to add the info from the sip-generated ones into the PI generated ones (that's why in the PI generator, I make the classes be a subclass of the class from the one in the module extension). This allows to keep the same docstrings generated. Thus, the methods defined in Python in the real py files (eg core.py), it is expected that they don't appear from sip-generated files. |
But your observation about properties is interesting |
Fixes #NNNN