Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Replace str find with in #279

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Conversation

echoix
Copy link
Owner

@echoix echoix commented Nov 2, 2024

No description provided.

echoix added 27 commits November 3, 2024 16:04
…in" check for projlabel or projection string
…asets in gui/wxpython/timeline/frame.py and gui/wxpython/tplot/frame.py
…sets in gui/wxpython/timeline/frame.py and gui/wxpython/tplot/frame.py
…nstructor to show that x, y and z are not only integers.
@echoix echoix force-pushed the replace-str-find-with-in branch from f3d9df7 to 4d75e98 Compare November 3, 2024 16:04
Repository owner deleted a comment from github-actions bot Nov 3, 2024
Repository owner deleted a comment from github-actions bot Nov 3, 2024
Repository owner deleted a comment from github-actions bot Nov 3, 2024
Repository owner deleted a comment from github-actions bot Nov 3, 2024
Repository owner deleted a comment from github-actions bot Nov 3, 2024
class AnySpaceTimeT(SpaceTimeT[TT], Generic[TT]):
pass

# class AnySpaceTimeT(SpaceTimeT[TT]):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[black] reported by reviewdog 🐶

Suggested change
# class AnySpaceTimeT(SpaceTimeT[TT]):
# class AnySpaceTimeT(SpaceTimeT[TT]):

import copy
import os
import sys
import uuid
from abc import ABCMeta, abstractmethod
from datetime import datetime
from pathlib import Path
from typing import Generic
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ruff] reported by reviewdog 🐶

Suggested change
from typing import Generic
from typing import Generic, TYPE_CHECKING

from .abstract_dataset import AbstractDataset, AbstractDatasetComparisonKeyStartTime
from .abstract_map_dataset import AbstractMapDataset
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ruff] reported by reviewdog 🐶

Suggested change
from .abstract_map_dataset import AbstractMapDataset

@@ -42,7 +47,10 @@
###############################################################################
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ruff] reported by reviewdog 🐶

Suggested change
###############################################################################
if TYPE_CHECKING:
from .abstract_map_dataset import AbstractMapDataset
###############################################################################

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant