route: read, store and output metric as uint32_t #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding a route metric greater than 0x7fff_ffff leads to an unintended wrap when treating the metric as an unsigned int (`%d`) thus incorrectly rendering the metric as negative. Formatting using `%u` corrects the issue. Relevant Linux patch: https://lore.kernel.org/netdev/20241212161911.51598-1-code@mguentner.de/ This commit does not require a patched kernel or vice versa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a route metric greater than 0x7fff_ffff leads to an unintended wrap when treating the metric as an
unsigned int (
%d) thus incorrectly rendering the metric as negative. Formatting using%ucorrects the issue.Relevant Linux patch:
https://lore.kernel.org/netdev/20241212161911.51598-1-code@mguentner.de/
This commit does not require a patched kernel or vice versa.